Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Signalements] Le tri de la liste ne fonctionne plus #2367

Merged
merged 2 commits into from
Jul 24, 2023
Merged

[Signalements] Le tri de la liste ne fonctionne plus #2367

merged 2 commits into from
Jul 24, 2023

Conversation

ivangabriele
Copy link
Member

@ivangabriele ivangabriele commented Jul 19, 2023 •
edited
Loading

Linked issues

  • Tests E2E (Cypress)

@ivangabriele ivangabriele changed the title Ivan/fix reporting list sorting [Signalements] Le tri de la liste ne fonctionne plus Jul 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

louptheron
louptheron reviewed Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@louptheron louptheron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
T'as pu essayer en local le tri par vesselName et validationDate ? J'ai l'impression que la date affichée ou triée n'était pas bonne, mais à vérifier!

@ivangabriele
Copy link
Member Author

Ok je vérifie ça

@ivangabriele
Copy link
Member Author

Ces deux props sont bien ordonnées chez moi du coup je merge ^^.

@ivangabriele ivangabriele merged commit c0377f3 into master Jul 24, 2023
@ivangabriele ivangabriele deleted the ivan/fix-reporting-list-sorting branch July 24, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louptheron louptheron louptheron left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Signalements] Le tri de la liste ne fonctionne plus
2 participants
@ivangabriele @louptheron